Misc. fixes and improvements for unused assignment detection #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while loop, so the code inside the loop condition won't be mixed with the code inside the loop body
… on a label defined after the use, inside of the same loop
MCVE:
```
main()
{
for (new x = 5; --x != 0;)
{
if (x == 2)
{
x = 1;
goto lbl_cont;
}
x = 3; // false-positive warning 240
lbl_cont:
}
}
```
|
This issue has been automatically marked as stale because it has not had recent activity. |
|
It would be good if REMOTE_FUNC__ static void:yrt_7(&a, &b, c, &d)
{
//print("yrt_7 called");
a = 8;
b = a;
c += d;
d -= 4;
#pragma unused c
}I get a warning on the |
|
@Y-Less Thanks, I forgot to reset the "modified" flag when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does the following:
++,--, and compound assignment operators (+=,-=,*=etc,)gotois used inside of a loop, on a label defined after the use, inside of the same loop (see Another warning 240 false positive. #669 (comment)).Which issue(s) this PR fixes:
Fixes #669
What kind of pull this is:
Additional Documentation: